Hi Aaron, Thanks for this. I think this made it clear we needed an extensions mechanism for yocto-autobuilder-helper (note this patch is against yocto-autobuilder-helper, not yocto-autobuilder2).
I've just pushed a change to yocto-autobuilder2 which should allow it to load extra json files instead of the standard config.json. What I'd propose is we add a config-intel-qa.json file there and that we add these extra definitions to that file (or maybe a config-intel- lava-qa.json?). Right now the simplistic logic in loadconfig() won't allow the simple addition/replacement of an entry within a dict/list but that is something which should be easily fixed. I am rather worried about this meta-minnow repository. We ideally want to test the artefacts the standard system builds, not change their configuration. It looks like the layer simply builds an extra kernel module. Is there a reason we can't enable upstream in the kernels? Also, "meta-minnow" is a very confusing name for what is a very specific purpose layer related to lava automated testing. The README in the layer is also incomplete/inaccurate. Can you have a look at the above and see if you think we can rework this as above and possibly drop meta-minnow entirely? Cheers, Richard On Tue, 2018-06-19 at 16:05 +0800, Aaron Chan wrote: > Signed-off-by: Aaron Chan <aaron.chun.yew.c...@intel.com> > --- > config.json | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/config.json b/config.json > index 808fefc..e79fae3 100644 > --- a/config.json > +++ b/config.json > @@ -230,6 +230,23 @@ > "MACHINE" : "genericx86-64" > } > }, > + "nightly-x86-64-bsp" : { > + "MACHINE" : innaccurate"intel-corei7-64", > + "SDKMACHINE" : "x86_64", > + "BBTARGETS" : "core-image-sato-sdk", > + "extravars" : [ > + "DISTRO_FEATURES_append = \" systemd\"", > + "IMAGE_INSTALL_append = \" udev util-linux > systemd\"", > + "IMAGE_FSTYPES = \"tar.gz\"", > + "CORE_IMAGE_EXTRA_INSTALL += \"python3 python3-pip > python-pip git socat apt dpkg openssh\"" > + ], > + "NEEDREPOS" : ["poky", "meta-intel", "meta-minnow", > "meta-openembedded"], > + "ADDLAYER" : [ > + "${BUILDDIR}/../meta-intel", > + "${BUILDDIR}/../meta-minnow", > + "${BUILDDIR}/../meta-openembedded/meta-python" > + ] > + }, > "nightly-world" : { > "MACHINE" : "qemux86", > "SDKMACHINE" : "x86_64", > @@ -738,6 +755,11 @@ > "url" : "git://git.yoctoproject.org/meta-gplv2", > "branch" : "master", > "revision" : "HEAD" > + }, > + "meta-minnow" : { > + "url" : "https://github.com/alimhussin2/meta-minnow", > + "branch" : "master", > + "revision" : "HEAD" > } > } > } > -- > 2.7.4 > -- _______________________________________________ yocto mailing list yocto@yoctoproject.org https://lists.yoctoproject.org/listinfo/yocto