On Thu, 2018-07-05 at 13:34 +0800, Aaron Chan wrote:
> This fix is to move clobberdir from python2 to python3 to resolve
> unicode data
> in python2 and change the data extraction expansion from
> ourconfig["TRASH_DIR"]
> to utils.getconfig("TRASH_DIR", ourconfig) on "Clobber build dir"
> BuildStep
>
> Signed-off-by: Aaron Chan <aaron.chun.yew.c...@intel.com>
> ---
> janitor/clobberdir | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/janitor/clobberdir b/janitor/clobberdir
> index 5e04ed7..b05a876 100755
> --- a/janitor/clobberdir
> +++ b/janitor/clobberdir
> @@ -1,4 +1,4 @@
> -#!/usr/bin/env python2
> +#!/usr/bin/env python3
> #
> # Delete a directory using the ionice backgrounded command
> #
At this point I think we're all getting frustrated with this. Please
can you give patches a sanity check when you're sending them. You
mention in the commit message what you need to do but the getconfig()
change is missing from the patch itself. This has happened with several
previous patches too where there were pieces missing. I deal with a lot
of patches and I can't fix up each one.
The commit message mentions its fixing something but not what (a
regression introduced by a previous change).
In the interests of resolving this I've fixed up this commit and merged
it:
http://git.yoctoproject.org/cgit.cgi/yocto-autobuilder-helper/commit/?id=54f848380fc77a9b9523bd85cd1cdce075bfb96e
Cheers,
Richard
--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
