Hi,
A colleague gave a first look to my patch, and gave me advice about how to
improve it.
Here's a new version.
Regards,
On Mon, Feb 11, 2019 at 9:35 AM Yann CARDAILLAC <yann.cardail...@smile.fr>
wrote:
> Hi,
>
> If you need more details about how to reproduce just ask, or if that's not
> the correct mailing list, I'll be happy to post my message wherever it
> belongs.
>
> Regards,
>
> Yann
>
> On Mon, Jan 28, 2019 at 1:26 PM Yann CARDAILLAC <yann.cardail...@smile.fr>
> wrote:
>
>> Hi all,
>>
>> We found a possible bug with boucman_work as mentionned in the IRC.
>>
>> It seems that when using the SDK there's an issue with the generated file
>> workspace/appends/linux-yocto_4.18.bbappend (or equivalent depending on
>> kernel and distro).
>>
>> In the do_patch rule, if some script are intended to be applied in
>> another language than python it will fail. I had the case with my BSP
>> (phytec). We had to change the rule with :
>>
>> do_patch[noexec] = "1"
>>
>> so that the rule is not executed which was what was probably intended
>> with the former :
>>
>> do_patch() {
>> :
>> }
>>
>> Here's the patch we would use to fix that. It patch the scipt
>> scripts/lib/devtool/standard.py so that it properly generate the bbappend
>> file. Please, do not hesitate to give me any feedback on my patch.
>>
>> Regards,
>>
>> --
>> [image: SMILE] <http://www.smile.eu/>
>>
>> 20 rue des Jardins
>> 92600 Asnières-sur-Seine
>> *Yann CARDAILLAC*
>> Ingénieur Linux Embarqué
>>
>> [image: email] yann.cardail...@smile.fr
>> [image: url] http://www.smile.eu
>>
>> [image: Twitter] <https://twitter.com/GroupeSmile> [image: Facebook]
>> <https://www.facebook.com/smileopensource> [image: LinkedIn]
>> <https://www.linkedin.com/company/smile> [image: Github]
>> <https://github.com/Smile-SA>
>>
>>
>> [image: eco] Pour la planète, n'imprimez ce mail que si c'est nécessaire
>>
>
>
> --
> [image: SMILE] <http://www.smile.eu/>
>
> 20 rue des Jardins
> 92600 Asnières-sur-Seine
> *Yann CARDAILLAC*
> Ingénieur Linux Embarqué
>
> [image: email] yann.cardail...@smile.fr
> [image: url] http://www.smile.eu
>
> [image: Twitter] <https://twitter.com/GroupeSmile> [image: Facebook]
> <https://www.facebook.com/smileopensource> [image: LinkedIn]
> <https://www.linkedin.com/company/smile> [image: Github]
> <https://github.com/Smile-SA>
>
>
> [image: eco] Pour la planète, n'imprimez ce mail que si c'est nécessaire
>
--
[image: SMILE] <http://www.smile.eu/>
20 rue des Jardins
92600 Asnières-sur-Seine
*Yann CARDAILLAC*
Ingénieur Linux Embarqué
[image: email] yann.cardail...@smile.fr
[image: url] http://www.smile.eu
[image: Twitter] <https://twitter.com/GroupeSmile> [image: Facebook]
<https://www.facebook.com/smileopensource> [image: LinkedIn]
<https://www.linkedin.com/company/smile> [image: Github]
<https://github.com/Smile-SA>
[image: eco] Pour la planète, n'imprimez ce mail que si c'est nécessaire
From 175e2f0c219348296b97129bccbd39823527e411 Mon Sep 17 00:00:00 2001
From: Yann CARDAILLAC <yann.cardail...@smile.fr>
Date: Thu, 14 Feb 2019 11:39:01 +0100
Subject: [PATCH] correct do_patch for kernel bbappend for sdk
do_patch rule of SDK's workspace/appends/linux-*.bbhappend may fail if script are not written in Python
that was the case with Phytec's BSP, the fix was to replace the do_patch rule with :
do_patch[noexec]="1" when the file was generated in scripts/lib/devtool/standard.py
Signed-off-by: Yann CARDAILLAC <yann.cardail...@smile.fr>
---
scripts/lib/devtool/standard.py | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/scripts/lib/devtool/standard.py b/scripts/lib/devtool/standard.py
index d14b7a6..5cb59f3 100644
--- a/scripts/lib/devtool/standard.py
+++ b/scripts/lib/devtool/standard.py
@@ -840,9 +840,7 @@ def modify(args, config, basepath, workspace):
if bb.data.inherits_class('kernel', rd):
f.write('SRCTREECOVEREDTASKS = "do_validate_branches do_kernel_checkout '
'do_fetch do_unpack do_kernel_configme do_kernel_configcheck"\n')
- f.write('\ndo_patch() {\n'
- ' :\n'
- '}\n')
+ f.write('\ndo_patch[noexec] = "1"\n')
f.write('\ndo_configure_append() {\n'
' cp ${B}/.config ${S}/.config.baseline\n'
' ln -sfT ${B}/.config ${S}/.config.new\n'
--
2.7.4
--
_______________________________________________
yocto mailing list
yocto@yoctoproject.org
https://lists.yoctoproject.org/listinfo/yocto
