Umm.... should a jira issue be marked closed if there are no unit tests? Without tests, how do you know the jira is really fixed/closed?
At the very least, a new jira issue should be opened to track the fact that tests are completely missing. However, I would say the original jira issue remains open until test coverage is "satisfactory". (definition open to interpretation) Basically, add a comment saying "source patch applied, unit tests required" or similar. Dan On Tuesday July 11 2006 7:41 am, Anders Hessellund Jensen (JIRA) wrote: > [ http://issues.apache.org/jira/browse/YOKO-33?page=all ] > > Anders Hessellund Jensen closed YOKO-33: > ---------------------------------------- > > Resolution: Fixed > Assign To: Anders Hessellund Jensen (was: Kresten Krab Thorup) > > I have added an RMI implementation based on code from our Trifork T4 > application server. > > There is no unit tests. > > Added files: > incubator/yoko/trunk/rmi/ > incubator/yoko/trunk/rmi/pom.xml (with props) > incubator/yoko/trunk/rmi/src/ > incubator/yoko/trunk/rmi/src/main/ > incubator/yoko/trunk/rmi/src/main/java/ > incubator/yoko/trunk/rmi/src/main/java/org/ > incubator/yoko/trunk/rmi/src/main/java/org/apache/ > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/ > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/ > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/api/ > > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/api/PortableRemo >teObjectExt.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/api/PortableRemo >teObjectExtDelegate.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/api/PortableRemo >teObjectState.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/api/RemoteOneway >Exception.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/ > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/AbstractObj >ectDescriptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/AnyDescript >or.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/ArrayDescri >ptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/BooleanDesc >riptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/ByteDescrip >tor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/CharDescrip >tor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/ClassDescri >ptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/CopyRecursi >onException.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/CopyRecursi >onResolver.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/CopyState.j >ava (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/CorbaObject >Reader.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/CorbaObject >Writer.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/DateValueDe >scriptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/DoubleDescr >iptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/ExceptionDe >scriptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/FVDValueDes >criptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/FieldDescri >ptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/FloatDescri >ptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/IDLEntityDe >scriptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/IOR.java > (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/IntegerDesc >riptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/LongDescrip >tor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/MethodDescr >iptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/ModelElemen >t.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/ObjectReade >r.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/ObjectWrite >r.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/PortableRem >oteObjectExtImpl.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/PortableRem >oteObjectImpl.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RMIInitiali >zer.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RMIIntercep >tor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RMIPersiste >ntStub.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RMIRemoteSt >ub.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RMIServant. >java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RMIState.ja >va (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RMIStub.jav >a (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RMIStubDesc >riptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RMIStubHand >ler.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RMIStubInit >ializer.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RemoteClass >Descriptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RemoteDescr >iptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RemoteInter >faceDescriptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/RunTimeCode >BaseImpl.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/ShortDescri >ptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/SimpleDescr >iptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/StringDescr >iptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/StubBuilder >.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/StubImpl.ja >va (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/TypeDescrip >tor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/TypeReposit >ory.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/UtilImpl.ja >va (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/ValueDescri >ptor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/ValueHandle >rImpl.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/impl/VoidDescrip >tor.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/ > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/ByteBuffer. >java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/ByteString. >java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/ClassLoader >Local.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/ClientUtil. >java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/DynamicHash >Map.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/GenericMap. >java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/NodeleteSyn >chronizedMap.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/PriorityQue >ue.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/Queue.java > (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/StreamUtil. >java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/StringUtil. >java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/corba/ > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/corba/Field >.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/corba/POAOb >ject.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/stub/ > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/stub/BCELCl >assBuilder.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/stub/Method >Ref.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/stub/Stub.j >ava (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/stub/StubCl >ass.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/stub/StubHa >ndler.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/stub/StubIn >itializer.java (with props) > incubator/yoko/trunk/rmi/src/main/java/org/apache/yoko/rmi/util/stub/Util.j >ava (with props) incubator/yoko/trunk/rmi/src/test/ > incubator/yoko/trunk/rmi/src/test/java/ > > > RMI/IIOP implementation > > ----------------------- > > > > Key: YOKO-33 > > URL: http://issues.apache.org/jira/browse/YOKO-33 > > Project: Yoko - CORBA Server > > Type: Bug > > > > Reporter: Kresten Krab Thorup > > Assignee: Anders Hessellund Jensen > > Attachments: trifork-rmiiiop.tgz > > > > The attached tgz includes Triforks rmi/iiop implementation, which may be > > used as a starting point for the Yoko projects's implementation hereof. > > The code doesn't compile as it is ripped right out of the Trifork T4 > > application server. (follow up email coming up) -- J. Daniel Kulp Principal Engineer IONA P: 781-902-8727 C: 508-380-7194 F:781-902-8001 [EMAIL PROTECTED]
