[
https://issues.apache.org/jira/browse/YOKO-320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12487219
]
Lars Kühne commented on YOKO-320:
---------------------------------
I did a quick review:
* Consider changing the class name, leave out the 'WSDL' (the class implements
a IDL->IDL transformation that has nothing to do with WSDL).
* You are using the platform default file encoding when opening files, and when
converting recursive preprocessor calls back from byte[] to String. It would be
more appropriate to use ISO-8859-1 charset explicitly. Quote from the IDL spec:
"OMG IDL uses the ASCII character set, except for string literals and character
literals, which use the ISO Latin-1 (8859.1) character set."
* The preprocessor should write some location markers to the output stream when
changing the file. That way the final IDL compiler would have a chance to
create meaningful error messages with correct file / linenumber information.
See http://gcc.gnu.org/onlinedocs/gcc-4.1.1/cpp/Preprocessor-Output.html for an
example how this could be done.
* creating a new preprocessor for every include directive clobbers the define
state, the defines created in the including idl file will not be available when
preprocessing the included file.
* Infinite include recursion is not handled gracefully.
* There should be some support for system includes that don't come from the
filesytem (orb.idl), and for an include path.
I do have some code sitting on my hard drive that solves some of these issues.
I haven't touched it for a while, so please allow me some days to prepare it
for Apache-Land.
> IDLToWSDL tool cannot handle includes
> -------------------------------------
>
> Key: YOKO-320
> URL: https://issues.apache.org/jira/browse/YOKO-320
> Project: Yoko - CORBA Server
> Issue Type: Bug
> Components: Idl2Wsdl
> Affects Versions: v1.0.0
> Reporter: Balaji Ravi
> Assigned To: Balaji Ravi
> Fix For: v1.0.0
>
> Attachments: preprocessor.patch
>
>
> The IDLToWSDL tool cannot handle the include of another idl.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
