On Sat, 10 Jan 2015 11:28:39 +0100
Kristian Amlie <[email protected]> wrote:

> This is looking very very *very* nice!! I can pick and choose from any
> bank or root I want! Excellent!

Glad you like it :)

> One small issue I ran into though: It appears that the banks start from
> 1, instead of zero. Looking at the banks in the UI, it looks alright,
> but there is a bank on the top, "Unknown", is that expected?

This is an artefact of the way the gui works. The zeroth entry in the list used
to be blank and corresponds to no bank being selected. It is a catch in case
you have no config file, and hence really no defined current bank. It can also
occur if a bank has been set and then later deleted, but from the filesystem,
not internally.

I changed the label to showing 'undefined' as being more informative than just a
blank entry. In practice if you try to select this in the gui although it will
show that label, the actual bank will be the last one selected. I keep meaning
to get around to preventing it being selected!

Although the banks seem offset by 1 they are correctly matched to their
alphabetic file positions starting from zero. A caveat there is that yoshi's
sorting routing is case sensitive so newbank will come *after* OldBank.

> Since you talked about assigning IDs to banks as well, maybe this is not
> worth looking into, I just thought I'd mention it. Great work in any case!

Once the banks have their own unique IDs this of course will be irrelevant, but
we will still need some way to identify an undefined/deleted bank.

-- 
Will J Godfrey
http://www.musically.me.uk
Say you have a poem and I have a tune.
Exchange them and we can both have a poem, a tune, and a song.

------------------------------------------------------------------------------
Dive into the World of Parallel Programming! The Go Parallel Website,
sponsored by Intel and developed in partnership with Slashdot Media, is your
hub for all things parallel software development, from weekly thought
leadership blogs to news, videos, case studies, tutorials and more. Take a
look and join the conversation now. http://goparallel.sourceforge.net
_______________________________________________
yoshimi-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/yoshimi-user

Reply via email to