I was wondering something about cmake versions. The commit below updated
the necessary cmake version to 3.0. Will, you do know why it was done?

I'm asking because I have one PC which is slightly older, still on
Ubuntu 14.04, and the highest cmake available there is 2.6. I have
reverted the patch manually and have not hit any problems. Maybe we can
consider getting it back to cmake 2.6 if it doesn't hurt anyone?

---------------------------------------------------

commit e3f05688755e505a669675c207b3c2ae0b48d249
Author: abrolag <[email protected]>
Date:   Fri Sep 22 22:37:11 2017 +0100

    Updated cmake policies

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
index 4ea2f61..b7e240f 100644
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
@@ -17,14 +17,14 @@
 #   You should have received a copy of the GNU General Public License
 #   along with yoshimi.  If not, see <http://www.gnu.org/licenses/>.

-# Modifed March 2017
+# Modifed September 2017

 project (Yoshimi)
-cmake_minimum_required (VERSION 2.6)
-cmake_policy (VERSION 2.6)
-cmake_policy (SET CMP0004 OLD)
+cmake_minimum_required (VERSION 3.0)
+cmake_policy (VERSION 3.0)
+cmake_policy (SET CMP0004 NEW)
 if (POLICY CMP0046)
-    cmake_policy (SET CMP0046 OLD)
+    cmake_policy (SET CMP0046 NEW)
 endif (POLICY CMP0046)
 set (CMAKE_CXX_STANDARD 11) # we seem to need both for
 add_definitions(-std=gnu++11) # various versions of cmake

---------------------------------------------------

-- 
Kristian

------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
yoshimi-user mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/yoshimi-user

Reply via email to