On Wed, 2007-02-21 at 12:28 -0500, James Bowes wrote: > seth vidal wrote: > > anyway - let me know what you think and if we like it, I'll commit it. > > "This is awesome" he says, as he segues into his criticisms of the patch.
criticism of the patch is fine. I wasn't sure I was happy with everything there but I wanted some critique to do it more nicely. > > Can self._ts be left off of YumBase entirely, and have the property live > on the depsolver? well the property living in the depsolver means it shows up in the YumBase, too. Since it subclasses it. > It might be best to have the logic to see if the field is already > populated live outside of the do* methods, so that their behaviour is > not changed. > > Can the new do* methods all be _do*? sure, but I don't want to do that in 3.2 unless we duplicate them. > Lastly, how about marking the existing do* methods as deprecated? :) sure. > > ? rpmUtils/updates.py.crack > > Oooh. what's in this file? > this is something I keep around to remind me of the stupid. -sv _______________________________________________ Yum-devel mailing list [email protected] https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
