On 4/25/07, Jeremy Katz <[EMAIL PROTECTED]> wrote:
This still looks like it's going to be overwriting previous values in one or two cases. And with dicts of lists and all the overhead of checking for existence, etc I suspect that much of the speed gain (I wasn't seeing a whole lot) is going to go away. Given some of the other places we're still making substantial speed gains, I suspect that this isn't that productive of a path really...
The speed gain is huge for a big upgrade, for example the upgrade from test3 to rawhide (+/- 380 packages) without this patch this takes 1:30 with it 30 seconds on my system a factor 3 speed-up. In case of a small upgrade (say less than 50 packages or so) it won't be very noticeable but the current algorithm slows down quadratically in the size of the upgrade. What are the cases where you think stuff will be overwritten? The checking for existence in the hashes shouldn't be any slower because the keys are still strings as they were in the original version of yum. The only thing this patch does is instead of creating a list of what is going away per package and then running through the whole transaction. O(n^2) we construct the whole list of what is going to go away first and then run that through all at once O(n). Greets, Gijs _______________________________________________ Yum-devel mailing list [email protected] https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
