On Tue, 2007-05-29 at 21:27 -0400, James Bowes wrote:
> This creates a new struct, SAXContext, that contains all common parts from
> the three other context, and teaches the PrimarySAXContext related code to
> use it.

 One minor comment:

> @@ -78,15 +84,17 @@ primary_parser_toplevel_start (PrimarySAXContext *ctx,
>                                 const char *name,
>                                 const char **attrs)
>  {
> +    SAXContext *sctx = (SAXContext *) ctx;
> +

 When doing conversions like this, I've found it's often better to use:

    SAXContext *sctx = &ctx->sctx;

...that way the compiler still does the type checking for you (and the
following code is obviously safe from aliasing).

-- 
James Antill <[EMAIL PROTECTED]>

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Yum-devel mailing list
[email protected]
https://lists.dulug.duke.edu/mailman/listinfo/yum-devel

Reply via email to