On Thu, 2007-07-05 at 03:04 +0530, Debarshi 'Rishi' Ray wrote: > Please find attached a patch to incorporate the persistent > enable/disable of repositories by editing the .repo files. > Repositories mentioned in yum.conf are still not supported. > > This is done using the following two methods: > YumRepository.enablePersistent(self) > YumRepository.disablePersistent(self) > > This is just a proof of concept and your comments are awaited.
the only thing I've noticed from your patch is that the following behavior, which works now will no longer work: /etc/yum/repos.d/bar.repo [bar] name=bar /etc/yum/repos.d/foo.repo baseurl=url://bar/repo enabled=1 [foo] name=foo /etc/yum/repos.d/quux.repo baseurl=url://foo/repo enabled=0 [quux] name=quux baseurl=url://quux/repo enabled=1 currently we concatenate all the .repo files then parse them (also we end up with a single parser instance) In your patch we'd have a parser instance for each of them and they would not be concatenated. now, I don't really have a problem with losing that behavior b/c I'm betting it is next to never used since most people who had not looked at that section of the code would never know how it happened anyway. :) However, What does everyone else think? -sv _______________________________________________ Yum-devel mailing list [email protected] https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
