On Tue, 24 Jul 2007, Jeremy Katz wrote:

On Tue, 2007-07-24 at 16:38 -0400, Seth Vidal wrote:
commit f691d64ea66087858ce30eccd8cadda97c855f00
Author: Seth Vidal <[EMAIL PROTECTED]>
Date:   Tue Jul 24 16:37:45 2007 -0400

    apply panu's patch to catch rpm signals:
    should potentially close 241278

I wonder if we want to make it so this happens in all cases, not just
for the CLI.  Otherwise, we're going to have to add something like this
for every CLI app using the yum api.  Which seems kind of lame.

Yes, something like a yum-level subclass of relevant urlgrabber progress thingies that check for signals and which yum api users can then further subclass without having to worry about this themselves.

Having to do it this way is kind of lame to begin with, but I was unable to find any better way without radically changing how the locking etc in rpm works.

Remember the current patch is just an initial proof of concept and for that it seems to work fine (been running it since last weekend and very much enjoying interruptable yum :) For example it doesn't make much sense to check on each progress update whether rpm supports signal checking, that could be done on module import time. And there might be other places that want to have periodical signal checking, during download is just the most obvious one.

        - Panu -
_______________________________________________
Yum-devel mailing list
[email protected]
https://lists.dulug.duke.edu/mailman/listinfo/yum-devel

Reply via email to