On Fri, 2007-07-27 at 11:37 +0200, Tim Lauridsen wrote:
> >
> 1, Make a lot of sense and it will make other excluding plugins faster to.
> 2, Make also a lot of sense, it will be logical, if the package object
> know how to exclude itself.
>
> So i think that both 1 & 2, is the way to go.
I committed them this afternoon
> > Alternatively, if there is something I've missed on why
> > pkgSack.delPackage() takes so long - let me know.
> >
> I have tried to track it down and i get a little confused, it look like
> the conduit.delPackges ends up calling
>
> po.repo.sack.delPackage(po)
>
> conduit.delPackage(po)
> -> self._base.pkgSack.delPackage(po) = MetaSack.delPackage
> (self._base.pkgSack = self._base._pkgSack = self._base.repos.pkgSack =
> MetaSack())
> -> po.repo.sack.delPackage(po) = YumSqlitePackageSack.delPackage
> (po.repo.sack = YumSqlitePackageSack() )
> -> def delPackage(self, obj):
> if not self.excludes.has_key(obj.repo):
> self.excludes[obj.repo] = {}
> self.excludes[obj.repo][obj.pkgId] = 1
> self.pkglist = None
>
>
> I took a look a the change history for MetaSack, it look like it have be
> fixed a earlier this year.
> http://devel.linux.duke.edu/gitweb/?p=yum.git;a=history;f=yum/packageSack.py;h=fce183f6a3450d0bb9f3627607cee5064eb0d20d;hb=HEAD
>
> So now i totally confused, please enligthen me :)
it wasn't fixed earlier, it was made better, but it still sucked.
-sv
_______________________________________________
Yum-devel mailing list
[email protected]
https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
