On Fri, 2007-08-10 at 18:53 +0200, Tim Lauridsen wrote: > seth vidal wrote: > > Here's my first go at the rpm transaction callback as part of the yum > > module. I've made a display callback which I think adequately covers the > > needs of a callback but please let me know if it doesn't. > > > > rpmtrans.py is the file - just drop it in your yum/ subdir of a git > > checkout > > > > ts-test.py is just something I was using to test it and kinda play > > around a bit. > > > > the SimpleCliCallBack was just enough for me to know it was working and > > have it make some sense out of what I was seeing. It, clearly, should be > > enhanced. > > > > however we should just be able to provide a TransactionDisplayCallback > > in output.py which we pass in for the yum cli. > > > > > > -sv > > > > > Look good, Maybe split out the functionality done in > RPMTransaction.callback in some functions like i have done here[1], it > make the code much more easier to read (IMHO) and make it easier to > extend in a child class. >
Well, the hope is no one will have to replace the RPMTransaction.callback at all - just add the display handler. However, you have a good point - doing it the way you have described will make it easier to subclass. I'll do that. Thanks, -sv _______________________________________________ Yum-devel mailing list [email protected] https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
