On Mon, 2008-02-11 at 20:01 -0500, seth vidal wrote: > On Mon, 2008-02-11 at 19:42 -0500, James Bowes wrote: > > Hi all: > > > > The attached patch adds skip-broken output to the yum cli's summary bit, > > like so: > > > > ============================================================================= > > Package Arch Version Repository Size > > ============================================================================= > > Updating: > > openbox-libs x86_64 3.4.5-1.fc8 updates 45 k > > Skipped: > > frobnitz x86_64 0.0.1 badrepo 165 k > > frobnitz-libs x86_64 0.0.1 badrepo 100 k > > libdc1394 x86_64 2.0.1-3.fc8 updates 111 k > > > > Transaction Summary > > ============================================================================= > > Install 0 Package(s) > > Update 1 Package(s) > > Remove 0 Package(s) > > > > So, I didn't add a count of skipped packages at the end, but that might be > > nice > > to show when some packages are actually skipped, or if skip-broken is > > enabled > > (rather than all the time). > > > > The code itself puts the skipped packages into the transaction info in a new > > 'skipped' array. While not used by rpm proper, this feels like a good place > > for > > it to be. > > > > What does everyone think? > > Does it play hell if I do something like: > > my = yum.YumBase() > my.install(foo) > ... magic-here ... > if len(my.tsInfo) > 0:
No because a txmbr isn't created and nothing is added to the pkgdict, but the bigger picture here is that IMO this shouldn't be part of the "Transaction Data" class. Although it'd be nice to see the above output, and data available for other API users ... so I'm not sure where to put it, maybe as part of the Depsolve class? -- James Antill <[EMAIL PROTECTED]> Red Hat
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Yum-devel mailing list [email protected] https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
