On Tue, 2008-02-12 at 14:32 +0100, Florian Festi wrote: > Hi! > > I found another piece of code that does updates - and does it a bit > different. The attached patch replaces it by a call to YumBase.update(). > > It also fixes a problem when processing "problems" of packages that got > already removed. > > This patch fixes the failing UpdateForDependency2 test cases just added. > (May be it would make sense to review them first) > > Comments? Ideas why it will fail? > > Florian > > BTW: I am still unhappy with the result of .update() and friends. It is > still quite complicated the find out what they actually did. Reason for this > is the IMHO insane API of TransactionInfo that returns just arbitrary > transaction member objects in its .add* methods.
Why is returning the txmbrs insane? update/install/remove all return the list of items that they added to the transaction set. The members themselves provide the why and the what. Your patch seems reasonable, though I think adding some additional debug information as to what it is going to do would be good. -sv _______________________________________________ Yum-devel mailing list [email protected] https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
