On Thu, 2008-02-14 at 12:16 -0500, Florian Festi wrote:
> +        if result == 0:
> +            result = cmp(hash(self), hash(other))
> +            if self is other:
> +                return 0
> +            if result == 0:
> +                return 1
> +        return result

 The above says that when they hash to the same thing but aren't the
same object then return 1 ... that seems wrong, the main problem being
that cmp(x, y) and cmp(y, x) can both return 1.
 I think you want:

if not result:
    return cmp(id(self), id(other))

-- 
James Antill <[EMAIL PROTECTED]>
Red Hat

Attachment: signature.asc
Description: This is a digitally signed message part

_______________________________________________
Yum-devel mailing list
[email protected]
https://lists.dulug.duke.edu/mailman/listinfo/yum-devel

Reply via email to