On Mon, 2008-02-18 at 13:50 +0100, Florian Festi wrote: > Hi! > > I wrote this patch to fix the behavior of TransactioInfo.add*. It adds a > "return_" parameter which can be 'one', 'all' or 'new' for all methods in > question - including .add() itself. > > While I don't like this whole thing there simply didn't came a better > solution to my mind. Any suggestions for enhancement are welcome.
So given it builds all the values into the result dict, I'd say the two behaviours we want are: 1) return result['one']. 2) return result The first is a compat. thing so we don't have to change all the callers ... if that isn't a problem I'd recommend just changing it to always return result. If we need the compat. behaviour then I'd suggest the parameter name be something like "all_transaction_data". Also addTrueInstall() doesn't have a return after your patch. -- James Antill <[EMAIL PROTECTED]> Red Hat
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Yum-devel mailing list [email protected] https://lists.dulug.duke.edu/mailman/listinfo/yum-devel
