On Wed, 2009-03-04 at 10:16 +0100, Tim Lauridsen wrote:
> James Antill wrote:
> > repoclosure.py | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > New commits:
> > commit f7a73716cf9e0ec248eb06992378d60a779a1fd4
> > Author: James Antill <ja...@and.org>
> > Date: Tue Mar 3 11:55:59 2009 -0500
> >
> > Fix RepoClosure() API for spam-o-matic, and other users
> >
> > diff --git a/repoclosure.py b/repoclosure.py
> > index de612c3..0509fd3 100755
> > --- a/repoclosure.py
> > +++ b/repoclosure.py
> > @@ -63,8 +63,10 @@ def parseArgs():
> > (opts, args) = parser.parse_args()
> > return (opts, args)
> >
> > +# Note that this is a "real" API, used by spam-o-matic etc.
> > +# so we have to do at least some API guarantee stuff.
> > class RepoClosure(yum.YumBase):
> > - def __init__(self, pkgonly, arch = [], config = "/etc/yum.conf",
> > builddeps = False ):
> > + def __init__(self, arch=[], config="/etc/yum.conf", builddeps=False,
> > pkgonly=None):
> > yum.YumBase.__init__(self)
> > self.logger = logging.getLogger("yum.verbose.repoclosure")
> > self.arch = arch
> > _______________________________________________
> > http://lists.baseurl.org/mailman/listinfo/yum-commits
>
> My fault, i missed that when adding a patch.
>
> But this makes me think about, what is supposed to be API, i have never
> expected this to be considered as API.
> In my world it was just an internal repoclosure class, not supposed to be API
> stable.
>
It's not a stable api, necessarily. It's just something folks are going
to use b/c it is there, so when it changes in various ways they're also
going to mention that it changed.
I do not think we've made any promises about the stability of the class
interfaces in yum-utils in fedora. But in this case unbreaking it is
easy so we can unbreak it and everyone is happy.
So to be completely clear:
yum-utils don't have an api commitment - but if we don't have to break
it, then we shouldn't.
-sv
_______________________________________________
Yum-devel mailing list
Yum-devel@lists.baseurl.org
http://lists.baseurl.org/mailman/listinfo/yum-devel
