On Thu, 2010-07-01 at 15:37 -0400, seth vidal wrote: > On Wed, 2010-06-30 at 18:26 -0400, James Antill wrote: > > Amusingly this also fixes a few weird edge case bugs. > > --- > > yum/packages.py | 373 > > ++++++++++++++++++++++++++++++++++++++----------------- > > 1 files changed, 258 insertions(+), 115 deletions(-) > > > > > ACK the changes- they help make the code less rpm-y, too, which is nice.
Yeh :). > pushing a yum base object into there will be 'fun'. Would it be possible > to only shove the plugins object into it for plugins.run()? I thought about doing: 1. Have the code split into "read data from rpmdb into PackageVerify objects" and "act on PackageVerify objects". With pkg.verify() calling both, and then some YumBase level function calling both with the plugin run in the middle. 2. Pass a callback into pkg.verify(), and add something to YumBase that people could use as a callback which would run the plugins. This is somewhat more generic than requiring a YumBase or YumBase.plugins directly, but should achieve the same end. ...#2 is what the later patches do, mainly because then we don't have to repeat all the args. for pkg.verify() in some YumBase interface. Also with the way .verify() works you can sort of do #1 instead, if you want. _______________________________________________ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel
