>         installed, available = base.doGroupLists(
>             patterns=[get_pattern(extcmds)])
> ...
> def get_pattern(extcmds):
>     if len(extcmds) > 1 and extcmds[1]:
>         return shlex.split(extcmds[1])[0] + "*"
>     return "*"

Not 100% sure about this but it feels wrong.
I think extcmds was already split by shell,
so this eats escapes.

Also not sure why you use the 1st component 
of the first non-option argument.  I'd just
use the last argument.

def get_pattern(extcmds):
    if len(extcmds) > 1 and extcmds[1]:
        return extcmds[-1] + "*"
    return "*"

> -        /usr/share/yum-cli/completion-helper.py -d 0 -C $@
> +        /usr/share/yum-cli/completion-helper.py -d 0 -C "$@"

That's ok, prevents double splitting here.
_______________________________________________
Yum-devel mailing list
[email protected]
http://lists.baseurl.org/mailman/listinfo/yum-devel

Reply via email to