On 12/21/2011 05:01 PM, Zdeněk Pavlas wrote:
Call this function with the error message instead of raising RepoError exception. This should work even with urlgrabber that does not support 'failfunc' callbacks. --- yum/misc.py | 5 ++++ yum/yumRepo.py | 64 ++++++++++++++++++++++++++++++++++++++----------------- 2 files changed, 49 insertions(+), 20 deletions(-)
Ack, only nitpicks:
+class Dummy:
"Dummy" doesn't describe what this does (DictAsInstance?). Also it is probably better to use new style class.
+ """ A dict-as-instance wrapper """ + def __init__(self, **kw): self.__dict__ = kw
If in the future is __dict__ nonempty this will break weirdly. self.__dict__.update(kw) perhaps? It is very cool trick but do you really need this? There's only two places below where you use it and you could just pass the exception parameter directly.
Ales _______________________________________________ Yum-devel mailing list [email protected] http://lists.baseurl.org/mailman/listinfo/yum-devel
