On Wed, 2012-01-11 at 07:59 -0500, Zdenek Pavlas wrote: > > A bit late, but... > > Fine, thanks for the feedback! > > > 1) why check for the exact type, and not use isinstance? > > The function was intended to work with 'str' arg only, > and the assert statement was meant to 'document' that. > > > 2) why use 'str' and exclude 'unicode', as groups are translated and > > can therefore be non-ASCII? The 'you groups' command works right now with > > parameters with accents in them for instance > > root@gibraltar:~> LC_ALL=de_DE.UTF-8 yum groups info 'Bücher > > It works only because both the pattern and group names are UTF8. > (yum/comps.py converts localised names to UTF8 and then does the matching).
That's what I thought and because of the docstring I thought parse_pattern() should handle group names (which may need to be in UTF-8): > > + """ Split a string to a list of package or group patterns. Nils -- Nils Philippsen "Those who would give up Essential Liberty to purchase Red Hat a little Temporary Safety, deserve neither Liberty [email protected] nor Safety." -- Benjamin Franklin, 1759 PGP fingerprint: C4A8 9474 5C4C ADE3 2B8F 656D 47D8 9B65 6951 3011 _______________________________________________ Yum-devel mailing list [email protected] http://lists.baseurl.org/mailman/listinfo/yum-devel
