On Fri, 2012-01-27 at 13:30 +0100, Zdeněk Pavlas wrote: > Q: Make it configurable? > --- > yum/__init__.py | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/yum/__init__.py b/yum/__init__.py > index 3c2f375..162d66e 100644 > --- a/yum/__init__.py > +++ b/yum/__init__.py > @@ -363,6 +363,7 @@ class YumBase(depsolve.Depsolve): > # update urlgrabber defaults > mc = self._conf.max_connections > if mc > 0: default_grabber.opts.max_connections = mc > + default_grabber.opts.timedhosts = self._conf.cachedir + '/timedhosts'
Don't you need a hasattr() here? Also not obvious cachedir is a good place for it, one problem is that it fails in weird ways if someone has a repo. called "timedhosts" ... we could just move it to <cachedir>/main/timedhosts ... or put it in /var/lib/yum ... meh. Someone will probably eventually ask to make it configurable, for some reason ... but leaving it static until they do is fine. However make sure it behaves with multiple updaters (forgot to check that in urlgrabber patch, sorry) -- ie. write to new file and rename. _______________________________________________ Yum-devel mailing list Yum-devel@lists.baseurl.org http://lists.baseurl.org/mailman/listinfo/yum-devel
