On Fri, 27 Jan 2012 11:20:10 -0500 James Antill <[email protected]> wrote:
> On Wed, 2012-01-25 at 11:23 +0100, Zdeněk Pavlas wrote: > > - Dropped the MG's 'max_connections' option, added a global one. > > - Single download queue, mirror selected as late as possible. > > - Merged request dispatch & flushing loops. > > > > Also, dropped the 'GrabRequest' instance, which originally contained > > a copy of all mirrors. Replaced that with a set of failed mirrors. > > > > - No need to clone the mirror list to each request. > > - Now the master list could be shuffled during downloads, > > and further mirror selections could act on that. > > [...] > > > + while True: > > + if idx >= len(_async_queue): > > Might be worth some comments explaining bits. Eg. _async_queue will > grow as the loop is run. > > > + if not dl.running: break > > + perform(); continue > > Why do you keep putting things on one line? > I'd like to add this: This is bad style to put it on one line. It's not consistent with a lot of the rest of yum and just bleah. Zdenek, please don't do this. thanks, -sv _______________________________________________ Yum-devel mailing list [email protected] http://lists.baseurl.org/mailman/listinfo/yum-devel
