On Fri, Sep 7, 2012 at 5:23 PM, James Antill <[email protected]>wrote:
> On Fri, 2012-09-07 at 16:45 +0200, [email protected] wrote: > > Maybe I have mised something, but is dont remember seeing this patch on > > yum-devel :) > > Yeh, I'm not sure it got posted ... it was supposed to only be a > cosmetic change! As it looked like everyone was using repo.id when they > needed just the id and str(repo) when they wanted to print something to > the user. > > > I make yumex blow up, because > > > > repoid, metatype = name.split('/') > > > > dont act so good when you add change name from <repoid>/<metadata type> > to > > <repoid>/<release>/<arch>/<rmetadata type> :) > > It seems like PK did something similar too, and having two backward > incompatibilities seems like at least one too many. We could change it > to use repo.id for __str__ (with a big comment that it can't change > anytime soon), and then use repo.ui_id everywhere we want the nicer > output to the user ... that was actually my first plan but then I had > this great idea that __str__ would already be used for that so I might > as well just change it. > Or we could leave it and fix the two callers (and just remember not to > backport to F16/etc. without putting conflicts in). Thoughts? > > _______________________________________________ > Yum-devel mailing list > [email protected] > http://lists.baseurl.org/mailman/listinfo/yum-devel > I have allready fixed it upstream in yumex and it looks like pk have been fixed also :) but it would be nice if you don't back port it to F17, for a while Tim
_______________________________________________ Yum-devel mailing list [email protected] http://lists.baseurl.org/mailman/listinfo/yum-devel
