On 2012-10-25 20:48, James Antill wrote: > On Thu, 2012-10-25 at 00:12 +0300, Ville Skyttä wrote: >> Hello, >> >> completion-helper's suggestions aren't that useful in scenarios where >> multiple versions of packages are available/installed, for example when >> completing kernel(-devel) packages to remove etc. The fix should be >> easy, but the full nvra makes completion suggestions generally uglier >> than they were. >> >> So... thoughts/objections about the attached patch? > > Ideally we'd have the full list for all seven possibilities, I assume > that's too slow?
Dunno, but I sure wouldn't like the sheer number of completions offered if that was the case. > Have you tried just the four of: n, na, nvra, nevra? > If we can only have one then nvra seems like it'd be the most useful, > but possibly _look_ worst most of the time. n and na are redundant with nvra, anything without arch is IMO a no go given that multiarch setups are that common these days, and nevra output doesn't actually work for (some?) Epoch: 0/missing cases: # yum remove bash-0:4.2.37-2.fc17.x86_64 No Match for argument: bash-0:4.2.37-2.fc17.x86_64 ...and besides, I think it's rare enough to have two nevras in scope that differ only by e that we can just forget about it wrt completions. So IMNSHO there should be only one, either na (like it is now) or nvra. Given that you seem to be leaning towards nvra too, I'll push this soonish. _______________________________________________ Yum-devel mailing list [email protected] http://lists.baseurl.org/mailman/listinfo/yum-devel
