On 25. 2. 2013 at 11:36:27, Panu Matilainen wrote:
> On 02/25/2013 09:23 AM, Jan Zeleny wrote:
>
> Thumbs up for the concept, but see below for a few comments:
> > + retmsgs.append(_('This usually indicates inconsistent
> > state '\ + 'of rpmdb. Please run rpm -Va
> > --nofiles to '\ + 'see possible
> > issues.'))
>
> "Inconsistent state of rpmdb" is fairly ambiguous - it can easily be
> misinterpreted for internally messed up rpmdb that requires --rebuilddb.
> I think it'd be better to talk explicitly about pre-existing dependency
> issues to avoid that possibility for confusion.
>
> > + retmsgs.append(_('If there are none issues reported,
> > please '\
> That should probably be s/none/no/.
>
> This is an improvement over the current situation sure, but I think it
> should be possible to do better:
>
> Yum already checks for pre-existing (rpmdb) dependency issues and dumps
> out the information. So there shouldn't be a need for the user to run
> 'rpm -Va --nofiles', yum should be able to print out that information
> just as easily. That check could also be used to determine whether the
> user is encouraged to file a bug or not. Unless I'm missing something in
> how the thing works, that is...I don't think you are missing sonmething, I just wanted to provide this quick- and-dirty patch to stop the flow of mod_python issues coming in from Fedora right now. So please consider this only a short-term solution which can be picked up by someone else, With my Python efficiency I'm not sure it's worth it for me to poke deeper to yum ;-) Thanks for the review, I will send corrected patch in a bit. Jan
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Yum-devel mailing list [email protected] http://lists.baseurl.org/mailman/listinfo/yum-devel
