On Tue, 2013-04-30 at 17:21 -0400, Bill Nottingham wrote: > James Antill ([email protected]) said: > > On Tue, 2013-04-30 at 15:42 -0400, Bill Nottingham wrote: > > > --- > > > yum/comps.py | 17 ++++++++++++++++- > > > 1 file changed, 16 insertions(+), 1 deletion(-) > > > > It looks mostly fine, except: > > > > > diff --git a/yum/comps.py b/yum/comps.py > > > index fe5649d..04e002a 100755 > > > --- a/yum/comps.py > > > +++ b/yum/comps.py > > > @@ -366,6 +372,9 @@ class Environment(CompsObj): > > > if child.tag == 'groupid': > > > optionid = child.text > > > self._options[optionid] = 1 > > > + default = child.attrib.get('default') > > > + if default: > > > + self._defaultoptions[optionid] = 1 > > [...] > > Oof, right. Overassumption of boolean status here. How about the attached?
Yeh, looks fine to me. Pushed, and building -88 in rawhide. _______________________________________________ Yum-devel mailing list [email protected] http://lists.baseurl.org/mailman/listinfo/yum-devel
