> Why change _commonRetrieveDataMD_done to be revertable, and > apply/retry/etc. there instead of applying in the download phase.
I'd have to apply deltas and checksum the result from checkfunc callback.. and it blocks both the progress display and the multi-downloader scheduler. Checksumming is probably the biggest blocker here, and since open files are about 3-5 times larger, it might be bad. Also, when we download and checksum delta, then apply it, and the result does not match, we should not try other mirror. Now there's UrlGrabError(-3) that does this, but still we can't change the relative URL and retry.. IMO it has to be done in 3 steps: 1) get & checksum delta 2) unzip & apply & checksum the result 3) full DL if 2) fails. > And, again ... it's going to be a lot of debugging pain if the output > of the deltas don't correspond to anything verifiable from the repo. I do (open) checksum of the result. > At _best_ every time we have a weird bug we'll have to question if it's the > metadata and there will be no way to verify anything that happened. The output XML files are checked against repomd.xml on each run, (using the xattr checksum caching).. Still, local rebuild might produce slightly different .sqlite file than the one on the server.. should we check this, too? > To expand here, we pass the open_checksum ... so "all" we need to do is > compress it in the same way as upstream, and make sure it matches. That does not make sense.. Openchecksum has the same strength and comes from the same domain as closedchecksum.. why bother compressing? _______________________________________________ Yum-devel mailing list [email protected] http://lists.baseurl.org/mailman/listinfo/yum-devel
