Hello Leonardo
On 2016-05-13 11:37:21, Leonardo Taccari wrote:
> Hello Christian!
>
> Christian Hesse writes:
> > [...]
> > --- a/document.c
> > +++ b/document.c
> > @@ -109,12 +109,12 @@ pdf_document_save_as(zathura_document_t* document,
> > mupdf_document_t*
> > }
> >
> > fz_try (mupdf_document->ctx) {
> > - /* fz_write_document claims to accepts NULL as third argument but
> > doesn't.
> > + /* pdf_save_document claims to accepts NULL as third argument but
> > doesn't.
> > * pdf_write_document does not check if the third arguments is NULL
> > for some
> > * options. */
> >
> > - fz_write_options opts = { 0 }; /* just use the default options */
> > - fz_write_document(mupdf_document->ctx, mupdf_document->document,
> > (char*) path, &opts);
> > + pdf_write_options opts = { 0 }; /* just use the default options */
> > + pdf_save_document(mupdf_document->ctx, (pdf_document*)
> > mupdf_document->document, (char*) path, &opts);
> > } fz_catch (mupdf_document->ctx) {
> > return ZATHURA_ERROR_UNKNOWN;
> > }
> > [...]
> IIUC I think that the comment is no longer valid for the 1.9 API and so
> it can be simplified to just call pdf_save_document() with NULL instead
> of passing `opts' (I'm using the patches attached here:
> <https://lists.pwmt.org/archive/zathura/2016-April/056577.html>)
Could you send an updated patch against zathura-pdf-mupdf's develop branch?
Ideally something easily git am-able.
Thanks
--
Sebastian Ramacher
_______________________________________________
zathura mailing list
zathura@lists.pwmt.org
https://lists.pwmt.org/mailman/listinfo/zathura
