The question which came in my mind after changing the code was: does the 
performance of other queries suffer from this change, so I changed the script 
attached to the bug to test all ResultType

Before the change:

---> LeastPopularActor: get len(ids)=6 using .find_eventids() in 0.078450s
---> LeastPopularActor: get len(ids)=6 using .find_eventids() in 0.261053s
++++++ LeastPopularActor 332.763498996
---> LeastPopularMimeType: get len(ids)=1 using .find_eventids() in 0.066008s
---> LeastPopularMimeType: get len(ids)=1 using .find_eventids() in 0.206841s
++++++ LeastPopularMimeType 313.35702779
---> LeastPopularOrigin: get len(ids)=1 using .find_eventids() in 0.200927s
---> LeastPopularOrigin: get len(ids)=1 using .find_eventids() in 0.257056s
++++++ LeastPopularOrigin 127.935007932
---> LeastPopularSubjectInterpretation: get len(ids)=1 using .find_eventids() 
in 0.065896s
---> LeastPopularSubjectInterpretation: get len(ids)=1 using .find_eventids() 
in 0.207888s
++++++ LeastPopularSubjectInterpretation 315.479743982
---> LeastPopularSubjects: get len(ids)=6 using .find_eventids() in 0.721558s
---> LeastPopularSubjects: get len(ids)=6 using .find_eventids() in 0.774241s
++++++ LeastPopularSubjects 107.301266111
---> LeastRecentActor: get len(ids)=6 using .find_eventids() in 0.071438s
---> LeastRecentActor: get len(ids)=6 using .find_eventids() in 0.258033s
++++++ LeastRecentActor 361.19819913
---> LeastRecentEvents: get len(ids)=6 using .find_eventids() in 0.133322s
---> LeastRecentEvents: get len(ids)=6 using .find_eventids() in 0.247588s
++++++ LeastRecentEvents 185.706902626
---> LeastRecentMimeType: get len(ids)=1 using .find_eventids() in 0.064972s
---> LeastRecentMimeType: get len(ids)=1 using .find_eventids() in 0.211424s
++++++ LeastRecentMimeType 325.407228279
---> LeastRecentOrigin: get len(ids)=1 using .find_eventids() in 0.172430s
---> LeastRecentOrigin: get len(ids)=1 using .find_eventids() in 0.234929s
++++++ LeastRecentOrigin 136.246031658
---> LeastRecentSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.055954s
---> LeastRecentSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.185784s
++++++ LeastRecentSubjectInterpretation 332.029758658
---> LeastRecentSubjects: get len(ids)=6 using .find_eventids() in 0.488676s
---> LeastRecentSubjects: get len(ids)=6 using .find_eventids() in 0.537375s
++++++ LeastRecentSubjects 109.965477134
---> MostPopularActor: get len(ids)=6 using .find_eventids() in 0.069163s
---> MostPopularActor: get len(ids)=6 using .find_eventids() in 0.224269s
++++++ MostPopularActor 324.261352472
---> MostPopularMimeType: get len(ids)=1 using .find_eventids() in 0.056728s
---> MostPopularMimeType: get len(ids)=1 using .find_eventids() in 0.186340s
++++++ MostPopularMimeType 328.480587054
---> MostPopularOrigin: get len(ids)=1 using .find_eventids() in 0.176185s
---> MostPopularOrigin: get len(ids)=1 using .find_eventids() in 0.221803s
++++++ MostPopularOrigin 125.892285645
---> MostPopularSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.057706s
---> MostPopularSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.179496s
++++++ MostPopularSubjectInterpretation 311.053314383
---> MostPopularSubjects: get len(ids)=6 using .find_eventids() in 0.617611s
---> MostPopularSubjects: get len(ids)=6 using .find_eventids() in 0.685492s
++++++ MostPopularSubjects 110.990917401
---> MostRecentActor: get len(ids)=6 using .find_eventids() in 0.062013s
---> MostRecentActor: get len(ids)=6 using .find_eventids() in 0.218987s
++++++ MostRecentActor 353.129925952
---> MostRecentEvents: get len(ids)=6 using .find_eventids() in 0.128710s
---> MostRecentEvents: get len(ids)=6 using .find_eventids() in 0.256136s
++++++ MostRecentEvents 199.00231361
---> MostRecentMimeType: get len(ids)=1 using .find_eventids() in 0.064722s
---> MostRecentMimeType: get len(ids)=1 using .find_eventids() in 0.216302s
++++++ MostRecentMimeType 334.201220051
---> MostRecentOrigin: get len(ids)=1 using .find_eventids() in 0.172238s
---> MostRecentOrigin: get len(ids)=1 using .find_eventids() in 0.229335s
++++++ MostRecentOrigin 133.149875626
---> MostRecentSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.064796s
---> MostRecentSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.211639s
++++++ MostRecentSubjectInterpretation 326.623591661
---> MostRecentSubjects: get len(ids)=6 using .find_eventids() in 0.574415s
---> MostRecentSubjects: get len(ids)=6 using .find_eventids() in 0.620583s
++++++ MostRecentSubjects 108.03736898
---> OldestActor: get len(ids)=6 using .find_eventids() in 0.187836s
---> OldestActor: get len(ids)=6 using .find_eventids() in 0.363429s
++++++ OldestActor 193.482187396




After the change:

---> LeastPopularActor: get len(ids)=6 using .find_eventids() in 0.067574s
---> LeastPopularActor: get len(ids)=6 using .find_eventids() in 0.073416s
++++++ LeastPopularActor 108.645290129
---> LeastPopularMimeType: get len(ids)=1 using .find_eventids() in 0.056667s
---> LeastPopularMimeType: get len(ids)=1 using .find_eventids() in 0.065348s
++++++ LeastPopularMimeType 115.318980642
---> LeastPopularOrigin: get len(ids)=1 using .find_eventids() in 0.176049s
---> LeastPopularOrigin: get len(ids)=1 using .find_eventids() in 0.180256s
++++++ LeastPopularOrigin 102.389751938
---> LeastPopularSubjectInterpretation: get len(ids)=1 using .find_eventids() 
in 0.056742s
---> LeastPopularSubjectInterpretation: get len(ids)=1 using .find_eventids() 
in 0.065499s
++++++ LeastPopularSubjectInterpretation 115.433227028
---> LeastPopularSubjects: get len(ids)=6 using .find_eventids() in 0.603144s
---> LeastPopularSubjects: get len(ids)=6 using .find_eventids() in 0.614587s
++++++ LeastPopularSubjects 101.897248326
---> LeastRecentActor: get len(ids)=6 using .find_eventids() in 0.061859s
---> LeastRecentActor: get len(ids)=6 using .find_eventids() in 0.065901s
++++++ LeastRecentActor 106.534466478
---> LeastRecentEvents: get len(ids)=6 using .find_eventids() in 0.113045s
---> LeastRecentEvents: get len(ids)=6 using .find_eventids() in 0.122753s
++++++ LeastRecentEvents 108.587879235
---> LeastRecentMimeType: get len(ids)=1 using .find_eventids() in 0.055588s
---> LeastRecentMimeType: get len(ids)=1 using .find_eventids() in 0.061294s
++++++ LeastRecentMimeType 110.264933327
---> LeastRecentOrigin: get len(ids)=1 using .find_eventids() in 0.147410s
---> LeastRecentOrigin: get len(ids)=1 using .find_eventids() in 0.152782s
++++++ LeastRecentOrigin 103.644291763
---> LeastRecentSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.055602s
---> LeastRecentSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.062072s
++++++ LeastRecentSubjectInterpretation 111.635764883
---> LeastRecentSubjects: get len(ids)=6 using .find_eventids() in 0.490159s
---> LeastRecentSubjects: get len(ids)=6 using .find_eventids() in 0.500074s
++++++ LeastRecentSubjects 102.022787367
---> MostPopularActor: get len(ids)=6 using .find_eventids() in 0.068959s
---> MostPopularActor: get len(ids)=6 using .find_eventids() in 0.073598s
++++++ MostPopularActor 106.727055854
---> MostPopularMimeType: get len(ids)=1 using .find_eventids() in 0.056281s
---> MostPopularMimeType: get len(ids)=1 using .find_eventids() in 0.065397s
++++++ MostPopularMimeType 116.197645504
---> MostPopularOrigin: get len(ids)=1 using .find_eventids() in 0.172171s
---> MostPopularOrigin: get len(ids)=1 using .find_eventids() in 0.182678s
++++++ MostPopularOrigin 106.102720121
---> MostPopularSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.056552s
---> MostPopularSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.065529s
++++++ MostPopularSubjectInterpretation 115.87421373
---> MostPopularSubjects: get len(ids)=6 using .find_eventids() in 0.602938s
---> MostPopularSubjects: get len(ids)=6 using .find_eventids() in 0.614013s
++++++ MostPopularSubjects 101.836802159
---> MostRecentActor: get len(ids)=6 using .find_eventids() in 0.061366s
---> MostRecentActor: get len(ids)=6 using .find_eventids() in 0.066541s
++++++ MostRecentActor 108.43279407
---> MostRecentEvents: get len(ids)=6 using .find_eventids() in 0.113125s
---> MostRecentEvents: get len(ids)=6 using .find_eventids() in 0.121236s
++++++ MostRecentEvents 107.169728609
---> MostRecentMimeType: get len(ids)=1 using .find_eventids() in 0.055613s
---> MostRecentMimeType: get len(ids)=1 using .find_eventids() in 0.061016s
++++++ MostRecentMimeType 109.715422408
---> MostRecentOrigin: get len(ids)=1 using .find_eventids() in 0.168344s
---> MostRecentOrigin: get len(ids)=1 using .find_eventids() in 0.180191s
++++++ MostRecentOrigin 107.037386381
---> MostRecentSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.064601s
---> MostRecentSubjectInterpretation: get len(ids)=1 using .find_eventids() in 
0.071221s
++++++ MostRecentSubjectInterpretation 110.247789309
---> MostRecentSubjects: get len(ids)=6 using .find_eventids() in 0.567160s
---> MostRecentSubjects: get len(ids)=6 using .find_eventids() in 0.574446s
++++++ MostRecentSubjects 101.284616633
---> OldestActor: get len(ids)=6 using .find_eventids() in 0.188532s
---> OldestActor: get len(ids)=6 using .find_eventids() in 0.196313s
++++++ OldestActor 104.12729526


As far as I can see, there is no negative impact, alot of queries get faster, 
and some still stay relative slow, which is another issue to taggle.
-- 
https://code.launchpad.net/~thekorn/zeitgeist/fix-672965-opt_timerange_queries/+merge/40412
Your team Zeitgeist Framework Team is requested to review the proposed merge of 
lp:~thekorn/zeitgeist/fix-672965-opt_timerange_queries into lp:zeitgeist.

_______________________________________________
Mailing list: https://launchpad.net/~zeitgeist
Post to     : zeitgeist@lists.launchpad.net
Unsubscribe : https://launchpad.net/~zeitgeist
More help   : https://help.launchpad.net/ListHelp

Reply via email to