Launchpad has imported 7 comments from the remote bug at https://bugs.freedesktop.org/show_bug.cgi?id=88846.
If you reply to an imported comment from within Launchpad, your comment will be sent to the remote bug automatically. Read more about Launchpad's inter-bugtracker facilities at https://help.launchpad.net/InterBugTracking. ------------------------------------------------------------------------ On 2015-01-28T08:46:57+00:00 Albert Astals Cid wrote: If the lambda fails the code leaves a MainLoop around that breaks things (i.e. the Qt main glib loop). I'm attaching the patch that fixes the problem, the generated code with and the patch. Reply at: https://bugs.launchpad.net/ubuntu/+source/zeitgeist/+bug/1415374/comments/0 ------------------------------------------------------------------------ On 2015-01-28T08:48:09+00:00 Albert Astals Cid wrote: Created attachment 112905 The patch Add finally {} to try {} catch {} Reply at: https://bugs.launchpad.net/ubuntu/+source/zeitgeist/+bug/1415374/comments/1 ------------------------------------------------------------------------ On 2015-01-28T08:49:14+00:00 Albert Astals Cid wrote: Created attachment 112906 Generated .c code if unpatched Note that there's some return; error conditions where the loop is not exited correctly with g_main_loop_quit (_data1_->mainloop); Reply at: https://bugs.launchpad.net/ubuntu/+source/zeitgeist/+bug/1415374/comments/2 ------------------------------------------------------------------------ On 2015-01-28T08:49:52+00:00 Albert Astals Cid wrote: Created attachment 112907 Generated .c code if patched Note that all the exit paths properly have a g_main_loop_quit (_data1_->mainloop); Reply at: https://bugs.launchpad.net/ubuntu/+source/zeitgeist/+bug/1415374/comments/3 ------------------------------------------------------------------------ On 2015-01-28T08:51:06+00:00 Albert Astals Cid wrote: Please if possible credit this to "Albert Astals Cid <[email protected]>" and not to "Albert Astals Cid <[email protected]>" I'm just using my kde.org account since I didn't feel like creating a new one just for this. Reply at: https://bugs.launchpad.net/ubuntu/+source/zeitgeist/+bug/1415374/comments/4 ------------------------------------------------------------------------ On 2015-01-29T15:29:55+00:00 Albert Astals Cid wrote: Created attachment 112950 The patch Reply at: https://bugs.launchpad.net/ubuntu/+source/zeitgeist/+bug/1415374/comments/6 ------------------------------------------------------------------------ On 2015-01-29T15:35:56+00:00 Albert Astals Cid wrote: It's been commited. Reply at: https://bugs.launchpad.net/ubuntu/+source/zeitgeist/+bug/1415374/comments/7 ** Changed in: zeitgeist Status: Unknown => Fix Released ** Changed in: zeitgeist Importance: Unknown => Medium -- You received this bug notification because you are a member of Zeitgeist Framework Team, which is subscribed to Zeitgeist Framework. https://bugs.launchpad.net/bugs/1415374 Title: Log: Loop not properly cleaned up on failures in Log constructor Status in Zeitgeist Framework: Fix Released Status in zeitgeist package in Ubuntu: New Bug description: If the lambda fails the code leaves a MainLoop around that breaks things (i.e. the Qt main glib loop). Patches and stuff at https://bugs.freedesktop.org/show_bug.cgi?id=88846 To manage notifications about this bug go to: https://bugs.launchpad.net/zeitgeist/+bug/1415374/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~zeitgeist Post to : [email protected] Unsubscribe : https://launchpad.net/~zeitgeist More help : https://help.launchpad.net/ListHelp
