sust...@250bpm.com said: > On 10/11/2010 05:19 PM, Martin Lucina wrote: > > gdieth...@dcv.cl said: > >>> I guess I should have reviewed your change closely, but then you > >> obviously > >>> didn't react to that careful comment :-) > >>> > >>> At this time I will also note my unhapiness with the choice that > >> because > >>> of > >>> MSVC the version numbering now has to be manually updated in zmq.h > >> itself. > >>> But you insisted, so be it. > >> > >> How about this patch? It creates a single place where the version is > >> kept; you don't have to change configure.in anymore. > >> > >> If there is consensus, I could push this into the master repo. > > > > Having an extra include file around doesn't feel right either; > > Atually, Gonzalo's patch can be modified to pick the version from zmq.h. > > That would solve all the problems we have, no?
Right, so the source of the version number would be include/zmq.h, configure.in would get it from there and propagate it to Makefile and friends. Not an entirely bad idea. Ok, we can do this, but as the resident autoconf and shell expect I'll make the actual patch using suitably paranoid UNIX commands, test on Solaris, etc... For me, it's still missing the ability to add various "-foo" to the *package* version safely but I can live without that for now. -mato _______________________________________________ zeromq-dev mailing list zeromq-dev@lists.zeromq.org http://lists.zeromq.org/mailman/listinfo/zeromq-dev
