Hi Mikko!
mikko.koppa...@gmail.com said:
> [...]
>
> Mato,
> does this look ok?
This is great, except that the patch doesn't seem to apply against the
current master:
[dezo:zeromq2]$ git apply ~/0001-Prefix-all-custom-macros-with-AC_ZMQ_.patch
/home/mato/0001-Prefix-all-custom-macros-with-AC_ZMQ_.patch:341: trailing
whitespace.
fi
/home/mato/0001-Prefix-all-custom-macros-with-AC_ZMQ_.patch:762: trailing
whitespace.
AC_ZMQ_CHECK_LANG_FLAG([-fvisibility=hidden],
/home/mato/0001-Prefix-all-custom-macros-with-AC_ZMQ_.patch:763: trailing
whitespace.
[LIBZMQ_EXTRA_CFLAGS="-fvisibility=hidden
${LIBZMQ_EXTRA_CFLAGS}"],
/home/mato/0001-Prefix-all-custom-macros-with-AC_ZMQ_.patch:764: trailing
whitespace.
[AC_ZMQ_CHECK_LANG_FLAG(["-xldscope=hidden"],
/home/mato/0001-Prefix-all-custom-macros-with-AC_ZMQ_.patch:769: trailing
whitespace.
AC_ZMQ_CHECK_LANG_FLAG([-fvisibility=hidden],
error: patch failed: configure.in:223
error: configure.in: patch does not apply
After fixing the various "trailing whitespace" warnings it still fails with
the error about configure.in:223.
Another minor niggle is all the long lines, but I guess that's due to the
way autoconf is structured.
If you could fix the patch to apply cleanly to master so that I can sanity
check and test some of the combinations here then we'd be good to go.
Cheers,
-mato
_______________________________________________
zeromq-dev mailing list
zeromq-dev@lists.zeromq.org
http://lists.zeromq.org/mailman/listinfo/zeromq-dev
