Hi AJ,
Nice work. I have a few comments on style but the approach is the
right one afaics and you can send pull requests when you like.
-Pieter
Style comments:
Don't use {} around single statements:
if (!self) {
goto end;
}
Should be:
if (!self)
goto end;
Put 'else' on new line:
} else {
error = ENOMEM;
}
Should be:
else
error = ENOMEM;
Use spaces around punctuation:
assert(rc == 0);
Should be:
assert (rc == 0);
} else {
error = EINVAL;
}
_______________________________________________
zeromq-dev mailing list
[email protected]
http://lists.zeromq.org/mailman/listinfo/zeromq-dev
