On 22/01/2012, at 12:13 PM, Martin Sustrik wrote:
> On 19/01/12 17:05, john skaller wrote:
>
>> This is seriously bugged. You may not use the name DLL_EXPORT.
>> You must use a command line macro name specific to the library!
>> For example ZMQ_DLL_EXPORT.
>
> You mean that if zmq.h is included in a header file of another library that
> happens to define DLL_EXPORT, zmq functions would be exported from that
> library as well, which is not desirable for everyone. Right?
>
Yes, precisely. You need to use a name unique to your own library.
The convention in MS land is something like
BUILD_ZMQ
but it doesn't matter as long as you have ZMQ in it :)
BUILD_ZMQ would be cool for me if I make ZMQ a submodule of Felix,
then ZMQ would be built by own own Python scripts, and the naming convention
we use would just work "out of the box" but it isn't that hard to fix I suppose
(I didn't write the Felix build system, fbuild .. I always find Python a bit
difficult after getting used to statically typed languages .. :)
I'm tempted to make ZMQ a submodule of Felix so that it gets built
when Felix does, since it's now a core part of the standard library,
we shouldn't rely on external installation. Felix builds Tre, Re2,
and some other things from source for this reason.
--
john skaller
[email protected]
_______________________________________________
zeromq-dev mailing list
[email protected]
http://lists.zeromq.org/mailman/listinfo/zeromq-dev
