[ 
https://issues.apache.org/jira/browse/ZETACOMP-1?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010261#comment-13010261
 ] 

Jérôme Renard commented on ZETACOMP-1:
--------------------------------------

The ezcTemplateTranslationExtractor::run() [1] has never been tested so far.

I hardly see how to write a correct unit test for it given the complexity of 
the function.

1. 
https://fisheye6.atlassian.com/browse/zetacomponents/trunk/TemplateTranslationTiein/src/extractor.php?r=984914#to206

> [TemplateTranslationTieIn] Extractor hard coded file extension
> --------------------------------------------------------------
>
>                 Key: ZETACOMP-1
>                 URL: https://issues.apache.org/jira/browse/ZETACOMP-1
>             Project: Zeta Components
>          Issue Type: Bug
>          Components: TemplateTranslationTiein
>         Environment: all
>            Reporter: Maxime THOMAS - Wascou.org
>         Attachments: hardcodedfileextension.diff.gz
>
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> In the extractor, in the function run(), the "ezt" file extension is 
> hardcoded.
> So if I named all my templates "tpl", I have to walk around with inheriting 
> the extractor class and reimplementing the run function.
> To correct it, add a variable to the class with the extension type (could be 
> an array to match several types).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to