[
https://issues.apache.org/jira/browse/ZETACOMP-81?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050218#comment-13050218
]
[email protected] commented on ZETACOMP-81:
-------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/783/
-----------------------------------------------------------
(Updated 2011-06-16 05:06:02.239400)
Review request for zetacomponents.
Changes
-------
Stopped using time() and used $_SERVER["REQUEST_TIME"] as we do not actually
need time().
Stored it in a local variable for more readability as proposed James.
Summary
-------
Added a new ezcAuthenticationSessionOptions::idleTimeOut option to handle
user's inactivity.
This addresses bug ZETACOMP-81.
https://issues.apache.org/jira/browse/ZETACOMP-81
Diffs (updated)
-----
trunk/Authentication/src/options/session_options.php 1136288
trunk/Authentication/src/session/authentication_session.php 1136288
trunk/Authentication/tests/session/session_test.php 1136288
Diff: https://reviews.apache.org/r/783/diff
Testing
-------
Added two new unit tests :
- ezcAuthenticationSessionTest::testSessionIsValidIdleTimeout()
- ezcAuthenticationSessionTest::testSessionIsValidIdleTimeoutExpired()
php ./UnitTest/src/runtests.php --filter=ezcAuthenticationSessionTest --verbose
Authentication
PHPUnit 3.5.10 by Sebastian Bergmann.
Zeta Components:
Authentication:
ezcAuthenticationGeneralTest:
ezcAuthenticationSessionTest: ............
[...]
Thanks,
Jérôme
> Session timeout
> ---------------
>
> Key: ZETACOMP-81
> URL: https://issues.apache.org/jira/browse/ZETACOMP-81
> Project: Zeta Components
> Issue Type: Bug
> Components: Authentication
> Reporter: Philipp Kamps
> Attachments: patch.txt
>
>
> Not sure, but looks like the session timeout is strange. I have following
> code:
> $options = new ezcAuthenticationSessionOptions();
> $options->validity = 10;
> $session = new ezcAuthenticationSession( $options );
> I would expect a session timeout after 10 seconds __OF INACTIVITY__. But it
> looks like it's a total lifetime of 10 seconds, even when I'm active (
> constantly requesting more pages that start the session ).
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
