[
https://issues.apache.org/jira/browse/ZETACOMP-15?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13085004#comment-13085004
]
[email protected] commented on ZETACOMP-15:
-------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/671/#review1453
-----------------------------------------------------------
I think it is time for this patch to be committed in trunk/.
Without any comments by the end of the week I will commit it.
- Jérôme
On 2011-04-28 11:47:17, Jérôme Renard wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/671/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-04-28 11:47:17)
bq.
bq.
bq. Review request for zetacomponents.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Used iconv/mbstring to get multibyte safe string functions.
bq.
bq.
bq. This addresses bug ZETACOMP-15.
bq. https://issues.apache.org/jira/browse/ZETACOMP-15
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. trunk/Template/src/functions/string_code.php 1097375
bq. trunk/Template/src/functions/string_functions.php 1097375
bq. trunk/Template/src/structs/lower_to_upper.php PRE-CREATION
bq. trunk/Template/src/structs/upper_to_lower.php PRE-CREATION
bq. trunk/Template/src/template_autoload.php 1097375
bq. trunk/Template/src/unicode/generate_unicode_tables.php PRE-CREATION
bq. trunk/Template/tests/regression_test.php 1097375
bq.
trunk/Template/tests/regression_tests/functions/correct/string_functions.in
1097375
bq.
trunk/Template/tests/regression_tests/functions/correct/string_functions.out
1097375
bq. trunk/Template/tests/string_function_test.php PRE-CREATION
bq. trunk/Template/tests/suite.php 1097375
bq.
bq. Diff: https://reviews.apache.org/r/671/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Ran the unit test suite :
bq.
bq. PHP 5.3.2 (cli) (built: Apr 5 2011 21:42:43)
bq. Copyright (c) 1997-2010 The PHP Group
bq. Zend Engine v2.3.0, Copyright (c) 1998-2010 Zend Technologies
bq. with Xdebug v2.1.0, Copyright (c) 2002-2010, by Derick Rethans
bq.
bq. PHPUnit 3.5.10 by Sebastian Bergmann.
bq.
bq. Zeta Components:
bq.
bq. Template:
bq. ezcTemplateRegressionTest:
...................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................................
bq. ezcTemplateFileExceptionTest: .....
bq. ezcTemplateVariableCollectionTest: ..
bq. ezcTemplateValidationItemTest: ..
bq. ezcTemplateOutputContextTest: .
bq. ezcTemplateXhtmlContextTest: .
bq. ezcTemplateCursorTest: ........
bq. ezcTemplateWhitespaceRemovalTest: .....
bq. ezcTemplateTextBlockElementTest: .
bq. ezcTemplateOperatorTest: ...
bq. ezcTemplateCodeElementsTest: ........
bq. ezcTemplateSourceCodeTest: ................
bq. ezcTemplateCompiledCodeTest: .........
bq. ezcTemplateConfigurationTest: ....
bq. ezcTemplateCacheTest:
...........................................
bq. ezcTemplateCacheManagerTest: SSSSS
bq. ezcTemplateTest: .....................
bq. ezcTemplateLocaleTest: ..
bq. ezcStringFunctionTest: .............
bq.
bq. Time: 01:50, Memory: 27.75Mb
bq.
bq. OK, but incomplete or skipped tests!
bq. Tests: 1064, Assertions: 2081, Skipped: 5.
bq.
bq.
bq. Thanks,
bq.
bq. Jérôme
bq.
bq.
> Template string functions are not multibyte safe
> ------------------------------------------------
>
> Key: ZETACOMP-15
> URL: https://issues.apache.org/jira/browse/ZETACOMP-15
> Project: Zeta Components
> Issue Type: Improvement
> Components: Template
> Reporter: Andreas Schamberger
> Attachments: generate_unicode_tables.php, lower_to_upper.php,
> string_code.diff, string_function_test.php, string_functions.diff,
> upper_to_lower.php
>
>
> The template functions do not work with UTF-8 data as they only wrap the
> normal PHP functions. E.g. str_pad_left() does not work as expected.
> I attached the needed string functions. The remaining work is to replace the
> calls in the string_functions.php with these functions and replace
> substr/strlen with iconv_substr(), iconv_strlen()...
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
