Good point.  The current 'canmount' property is never accessed in the
kernel via dsl_prop_get_impl(), but future DSL-stored non-inheritable
properties might be.  I'll add the logic to dsl_prop_get_impl() as well.

- Eric

On Wed, Aug 30, 2006 at 05:41:32PM -0700, Matthew Ahrens wrote:
> Eric Schrock wrote:
> >http://cr.grommit.com/~eschrock/zfs-prop/
> 
> Shouldn't dsl_prop_get* all take into account the inheritability of 
> properties?  It looks like non-inheritable properties will be inherited 
> unless you are using dsl_prop_get_all().  It seems like the check for 
> inheritability needs to be in dsl_prop_get_impl() too.
> 
> --matt

--
Eric Schrock, Solaris Kernel Development       http://blogs.sun.com/eschrock

Reply via email to