> On Mon, Jun 25, 2007 at 02:34:21AM -0400, Dennis Clarke wrote:
note that it was well after 2 AM for me .. half blind asleep
that's my excuse .. I'm sticking to it. :-)
>>
>> > in /usr/src/cmd/zpool/zpool_main.c :
>> >
>>
>> at line 680 forwards we can probably check for this scenario :
>>
>> if ( ( altroot != NULL ) && ( altroot[0] != '/') ) {
>> (void) fprintf(stderr, gettext("invalid alternate root '%s': "
>> "must be an absolute path\n"), altroot);
>> nvlist_free(nvroot);
>> return (1);
>> }
>>
>> /* some altroot has been specified *
>> * thus altroot[0] and altroot[1] exist */
>>
>> else if ( ( altroot[0] = '/') && ( altroot[1] = '\0') ) {
>
> s/=/==/
yep ... that's what I intended. The above would bork royally.
>
>> (void) fprintf(stderr, "Do not specify / as alternate root.\n");
>
> You need gettext() here.
why ?
>
>> nvlist_free(nvroot);
>> return (1);
>> }
>>
>>
>> not perfect .. but something along those lines.
even worse .. I was looking in the wrong section of the code or zpool_main.c
if I get coffee and wake up .. maybe I can take another kick at that eh?
Dennis
_______________________________________________
zfs-discuss mailing list
zfs-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/zfs-discuss
