Finally, just to be clear, one last point:  the two fixes integrated
today only affect you if you've explicitly set dedup=fletcher4,verify.
To quote Matt:

> This is not the default dedup setting; pools that only used "zfs set 
> dedup=on" (or =sha256, or =verify, or =sha256,verify) are unaffected.

Jeff

On Mon, Nov 23, 2009 at 09:44:41PM -0800, Jeff Bonwick wrote:
> And, for the record, this is my fault.  There is an aspect of endianness
> that I simply hadn't thought of.  When I have a little more time I will
> blog about the whole thing, because there are many useful lessons here.
> 
> Thank you, Matt, for all your help with this.  And my apologies to
> everyone else for the disruption.
> 
> Jeff
> 
> On Mon, Nov 23, 2009 at 09:15:48PM -0800, Matthew Ahrens wrote:
> > We discovered another, more fundamental problem with 
> > dedup=fletcher4,verify. I've just putback the fix for:
> > 
> >     6904243 zpool scrub/resilver doesn't work with cross-endian 
> > dedup=fletcher4,verify blocks
> > 
> > The same instructions as below apply, but in addition, the 
> > dedup=fletcher4,verify functionality has been removed.  We will investigate 
> > whether it's possible to fix these isses and re-enable this functionality.
> > 
> > --matt
> > 
> > 
> > Matthew Ahrens wrote:
> > >If you did not do "zfs set dedup=fletcher4,verify <fs>" (which is 
> > >available in build 128 and nightly bits since then), you can ignore this 
> > >message.
> > >
> > >We have changed the on-disk format of the pool when using 
> > >dedup=fletcher4,verify with the integration of:
> > >
> > >    6903705 dedup=fletcher4,verify doesn't byteswap correctly, has lots 
> > >of hash collisions
> > >
> > >This is not the default dedup setting; pools that only used "zfs set 
> > >dedup=on" (or =sha256, or =verify, or =sha256,verify) are unaffected.
> > >
> > >Before installing bits with this fix, you will need to destroy any 
> > >filesystems that have had dedup=fletcher4,verify set on them.  You can 
> > >preserve your existing data by running:
> > >
> > >    zfs set dedup=<any other setting> <old fs>
> > >    zfs snapshot -r <old fs>@snap
> > >    zfs create <new fs>
> > >    zfs send -R <old fs>@snap | zfs recv -d <new fs>
> > >    zfs destroy -r <old fs>
> > >
> > >Simply changing the setting from dedup=fletcher4,verify to another 
> > >setting is not sufficient, as this does not modify existing data.
> > >
> > >You can verify that your pool isn't using dedup=fletcher4,verify by running
> > >    zdb -D <pool> | grep DDT-fletcher4
> > >If there are no matches, your pool is not using dedup=fletcher4,verify, 
> > >and it is safe to install bits with this fix.
> > >
> > >Build 128 will be respun to include this fix.
> > >
> > >Sorry for the inconvenience,
> > >
> > >-- team zfs
> > >
> > 
_______________________________________________
zfs-discuss mailing list
zfs-discuss@opensolaris.org
http://mail.opensolaris.org/mailman/listinfo/zfs-discuss

Reply via email to