[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12663566#action_12663566
 ] 

phunt edited comment on ZOOKEEPER-234 at 1/13/09 4:17 PM:
-----------------------------------------------------------------

The attached patches will:
  * remove the static stat classes
  * remove the src/java/jmx subdir and integrate into the mainline
    * as a result all zookeeper servers will now have jmx support by default
  * adds jmx support for log4j as well
  * fixes a number of issues with the structure and data in jmx for zk server(s)

The two attached patches should be applied as follows:

apply the first patch "step 1"

then:

mkdir src/java/main/org/apache/zookeeper/jmx
svn add src/java/main/org/apache/zookeeper/jmx
svn mv src/java/jmx/org/apache/zookeeper/server/ManagedUtil.java 
src/java/main/org/apache/zookeeper/jmx/.
svn mv src/java/jmx/org/apache/zookeeper/jmx/*.java 
src/java/main/org/apache/zookeeper/jmx
svn mv src/java/jmx/org/apache/zookeeper/jmx/server/*.java 
src/java/main/org/apache/zookeeper/server/.
svn mv src/java/jmx/org/apache/zookeeper/jmx/server/quorum/*.java 
src/java/main/org/apache/zookeeper/server/quorum/.
svn rm --force src/java/jmx

then:

apply second patch "step 3"

after this process the src/java/jmx directory should be no longer

run "ant test" to verify. also start a zkserver as follows and verify that 
jconsole can connect:

java -cp zookeeper-dev.jar:src/java/lib/log4j-1.2.15.jar:conf 
-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.local.only=false  
org.apache.zookeeper.server.quorum.QuorumPeerMain zoo.cfg

then: commit to svn if tests/smoketest all pass



      was (Author: phunt):
    The two attached patches should be applied as follows:

apply the first patch "step 1"

then:

mkdir src/java/main/org/apache/zookeeper/jmx
svn add src/java/main/org/apache/zookeeper/jmx
svn mv src/java/jmx/org/apache/zookeeper/server/ManagedUtil.java 
src/java/main/org/apache/zookeeper/jmx/.
svn mv src/java/jmx/org/apache/zookeeper/jmx/*.java 
src/java/main/org/apache/zookeeper/jmx
svn mv src/java/jmx/org/apache/zookeeper/jmx/server/*.java 
src/java/main/org/apache/zookeeper/server/.
svn mv src/java/jmx/org/apache/zookeeper/jmx/server/quorum/*.java 
src/java/main/org/apache/zookeeper/server/quorum/.
svn rm --force src/java/jmx

then:

apply second patch "step 3"

after this process the src/java/jmx directory should be no longer

run "ant test" to verify. also start a zkserver as follows and verify that 
jconsole can connect:

java -cp zookeeper-dev.jar:src/java/lib/log4j-1.2.15.jar:conf 
-Dcom.sun.management.jmxremote -Dcom.sun.management.jmxremote.local.only=false  
org.apache.zookeeper.server.quorum.QuorumPeerMain zoo.cfg

then: commit to svn if tests/smoketest all pass


  
> Eliminate using statics to initialize the sever.  Should allow server to be 
> more embeddable in OSGi enviorments.
> ----------------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-234
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-234
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: server
>            Reporter: Hiram Chirino
>            Assignee: Patrick Hunt
>             Fix For: 3.1.0
>
>         Attachments: ZOOKEEPER-234_step1.patch, ZOOKEEPER-234_step3.patch
>
>
> Patrick request I open up this in issue in this [email 
> thread|http://n2.nabble.com/ActiveMQ-is-now-using-ZooKeeper-td1573272.html]
> The main culprit I've noticed is:
> {code}
>         ServerStats.registerAsConcrete();
> {code}
> But there may be others.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to