[
https://issues.apache.org/jira/browse/ZOOKEEPER-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12674763#action_12674763
]
Mahadev konar commented on ZOOKEEPER-308:
-----------------------------------------
this is great!!!
comments/questions on the patch --
- what is the usefulness of the change in FileTxnLog, the flush has been moved
earlier i.e while flushing when rolling the logs. Is their some specific reason
for it?
- looks the outstanding changes on gives us a sorted order of zxid.... is it
possible to get rid of outstandingchanges assuming that if zxid is the first in
the outstandingchanges queue then zxid +1 will be the next one? I dont have a
strong opinion on it. Anyway the outstanding list should not use that much
memory.
- what is the purpose of writePacket(*, boolean) in follower.java. Why do we
need to an option on when to flush ?
- why is tcpNodelay an option? why is not it always set to true?
- leader.java (line 560) needs wrapping
- why is the Excpetion wrapped around to IOExcpetion in SerializeUtils.java?
All the lines in the deserializeSnapshot can only throw IOExcpeiton? Why do we
have to wrap around Exception?
> improve the atomic broadcast performance 3x
> -------------------------------------------
>
> Key: ZOOKEEPER-308
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-308
> Project: Zookeeper
> Issue Type: Improvement
> Components: server
> Reporter: Benjamin Reed
> Attachments: dat.png, ZOOKEEPER-308.patch, ZOOKEEPER-308.patch
>
>
> We need a benchmark for zab, the atomic broadcast protocol of zookeeper. we
> can also do some small tweaks to make zab go much faster.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.