[ https://issues.apache.org/jira/browse/ZOOKEEPER-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695477#action_12695477 ]
Hadoop QA commented on ZOOKEEPER-362: ------------------------------------- +1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12404562/ZOOKEEPER-362.patch against trunk revision 761433. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/14/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/14/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/14/console This message is automatically generated. > Issues with FLENewEpochTest > --------------------------- > > Key: ZOOKEEPER-362 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-362 > Project: Zookeeper > Issue Type: Bug > Affects Versions: 3.1.1 > Reporter: Flavio Paiva Junqueira > Fix For: 3.2.0 > > Attachments: ZOOKEEPER-362.patch, ZOOKEEPER-362.patch > > > I have been able to identify two reasons that cause FLENewEpochTest to fail: > 1- There is a race condition that is triggered when two peers try to > establish a connection to each other for leader election. Basically, if they > start roughly at the same time, the server with highest id will try to open > two connections. The two competing connections will lead to one notification > message to be lost. This message happens to be critical for this two process > scenario; > 2- The code to shut down a peer is not working well with the unit tests. For > this particular unit test, we need to be able to shut down a peer completely > to check the situation the test tries to reproduce. However, it seems that in > some runs timing causes the other peers to believe it is still alive, and end > up electing it. This peer, however, eventually shuts down and leader election > fails. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.