[ https://issues.apache.org/jira/browse/ZOOKEEPER-371?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699040#action_12699040 ]
Giridharan Kesavan edited comment on ZOOKEEPER-371 at 4/14/09 8:44 PM: ----------------------------------------------------------------------- {quote} run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go? {quote} This patch that I submitted is to run during the nightly to show up any changes b/w 3.1.1 and 3.2.0. But I understand the requirement that we want this jdiff as part of the patch test process, that way we can say whether a patch has introduced any api changes and do a +1/-1 based on that. I already have this in my task list and I would be working on this enhancement soon. tnx was (Author: gkesavan): {quote} run jdiff on svn trunk and then run jdiff on svn trunk+patch. If their is a change then we -1 the patch. That way we do not need to check in the 3.1.1 api docs. can we do that or doing what you suggest is the right way to go? {quote} This patch that I submitted is to run during the nightly to show up any any changes b/w 3.1.1 and 3.2.0. But I understand the requirement that we want this jdiff as part of the path test process, that way we can say whether a path has introduced any api changes and do a +1/-1 based on that. I already have this in my task list and I would be working on this enhancement soon. tnx > to implement jdiff > ------------------- > > Key: ZOOKEEPER-371 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-371 > Project: Zookeeper > Issue Type: Improvement > Components: build > Affects Versions: 3.2.0 > Environment: to implement jdiff > Reporter: Giridharan Kesavan > Assignee: Giridharan Kesavan > Fix For: 3.2.0 > > Attachments: zookeeper-371.patch > > -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.