[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12705842#action_12705842
 ] 

Hadoop QA commented on ZOOKEEPER-380:
-------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12407191/ZOOKEEPER-380.patch
  against trunk revision 769885.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 12 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    -1 core tests.  The patch failed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/61/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/61/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/61/console

This message is automatically generated.

> bookkeeper should have a streaming api so that its easier to store 
> checpoints/snapshots in bookkeeper.
> ------------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-380
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-380
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bookkeeper
>    Affects Versions: 3.1.0, 3.1.1
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.2.0
>
>         Attachments: ZOOKEEPER-380.patch, ZOOKEEPER-380.patch, 
> ZOOKEEPER-380.patch, ZOOKEEPER-380.patch, ZOOKEEPER-380.patch, 
> ZOOKEEPER-380.patch
>
>
> currently, bookkeeper api allows just a bytes interface which is 
> ld.write(bytes).
> We should have an interface like 
> Stream s = ledger.createStream() (I am not very sure of the interface right 
> now but will post a more concrete one after giving it a little more thought)
> now this stream can be used to wirte checkpoints as 
> s.write(bytes)
> and then closed to s.close() to close the snapshot. 
> This api could use the current api to implement snapshots as chunks of bytes 
> (buffered by stream s) that can be written via ld.write(bytes).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to