[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737809#action_12737809
 ] 

Hadoop QA commented on ZOOKEEPER-481:
-------------------------------------

+1 overall.  Here are the results of testing the latest attachment 
  
http://issues.apache.org/jira/secure/attachment/12415199/ZOOKEEPER-481-branch3.2.patch
  against trunk revision 799741.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac 
compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of 
release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/165/testReport/
Findbugs warnings: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/165/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: 
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-vesta.apache.org/165/console

This message is automatically generated.

> Add lastMessageSent to QuorumCnxManager
> ---------------------------------------
>
>                 Key: ZOOKEEPER-481
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-481
>             Project: Zookeeper
>          Issue Type: Bug
>          Components: leaderElection
>    Affects Versions: 3.1.1, 3.2.0
>            Reporter: Flavio Paiva Junqueira
>            Assignee: Flavio Paiva Junqueira
>             Fix For: 3.2.1, 3.3.0
>
>         Attachments: ZOOKEEPER-481-branch3.2.patch, 
> ZOOKEEPER-481-branch3.2.patch, ZOOKEEPER-481.patch, ZOOKEEPER-481.patch, 
> ZOOKEEPER-481.patch, ZOOKEEPER-481.patch
>
>
> Currently we rely on TCP for reliable delivery of FLE messages. However, as 
> we concurrently drop and create new connections, it is possible that a 
> message is sent but never received. With this patch, cnx manager keeps a list 
> of last messages sent, and resends the last one sent. Receiving multiples 
> copies is harmless. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to