[
https://issues.apache.org/jira/browse/ZOOKEEPER-542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762736#action_12762736
]
Hadoop QA commented on ZOOKEEPER-542:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12421444/ZOOKEEPER-542.patch
against trunk revision 822065.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/18/testReport/
Findbugs warnings:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/18/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/18/console
This message is automatically generated.
> c-client can spin when server unresponsive
> ------------------------------------------
>
> Key: ZOOKEEPER-542
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-542
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.2.0, 3.2.1
> Reporter: Christian Wiedmann
> Assignee: Christian Wiedmann
> Fix For: 3.3.0
>
> Attachments: ZOOKEEPER-542.patch, ZOOKEEPER-542.patch
>
>
> Due to a mismatch between zookeeper_interest() and zookeeper_process(), when
> the zookeeper server is unresponsive the client can spin when reconnecting to
> the server.
> In particular, zookeeper_interest() adds ZOOKEEPER_WRITE whenever there is
> data to be sent, but flush_send_queue() only writes the data if the state is
> ZOO_CONNECTED_STATE. When in ZOO_ASSOCIATING_STATE, this results in spinning.
> This probably doesn't affect production, but I had a runaway process in a
> development deployment that caused performance issues on the node. This is
> easy to reproduce in a single node environment by doing a kill -STOP on the
> server and waiting for the session timeout.
> Patch to be added.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
